SteveLauC
SteveLauC
Oops, I just noticed this is a duplicate of #1734
My current thought on this is that `impl From for Wrapper` can be `unsafe` because we cannot ensure the values set in those libc types are valid
> In order to get rid of the copy, we could also make `SockAddrLl` a newtype around `libc::sockaddr_ll` and let the user move all values into the constructor (hinting to...
Well, it is indeed weird, I didn't reproduce it either... Will investigate more.
I kinda think this error is a false positive? My guess on the reason why it is triggered is that we are directly casting a `c_long` to a raw pointer,...
It was made `unsafe` indeed for this argument, see #1245, so I think this would be a reasonable change.
> but since Sigaction's fields are not public, I cannot have this function inside my own library. So another way would be to make sigaction public, but I feel like...
My current concert of this kind of conversion is that it can be unsafe since we have no guarantee from the values set in those raw libc types, see https://github.com/nix-rust/nix/issues/2327#issuecomment-2053587739...
I am working on the CI issues, they are not related to this PR Update: CI fixed in #2394, you can rebase your branch now:)
* [x] for the following code snippet in `build.rs`, use `cargo::` rather than `cargo:` in `build.rs` (new syntax introduced in 1.77) > No longer needed since this PR #2490 ```rs...