nix icon indicating copy to clipboard operation
nix copied to clipboard

MSRV 1.77.0 TODO

Open asomers opened this issue 1 year ago • 1 comments
trafficstars

Whenever we raise the MSRV to 1.77.0 for any reason, we should [ ] Replace the memoffset::offset_of! macro with the builtin macro of the same name (https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html#offset_of) [ ] Use native CStr literals instead of CString::new

asomers avatar Apr 28 '24 17:04 asomers

  • [x] for the following code snippet in build.rs, use cargo:: rather than cargo: in build.rs (new syntax introduced in 1.77)

    No longer needed since this PR #2490

    // Below are Nix's custom cfg values that we need to let the compiler know
    println!("cargo:rustc-check-cfg=cfg(apple_targets)");
    println!("cargo:rustc-check-cfg=cfg(bsd)");
    println!("cargo:rustc-check-cfg=cfg(bsd_without_apple)");
    println!("cargo:rustc-check-cfg=cfg(linux_android)");
    println!("cargo:rustc-check-cfg=cfg(freebsdlike)");
    println!("cargo:rustc-check-cfg=cfg(netbsdlike)");
    println!("cargo:rustc-check-cfg=cfg(solarish)");
    println!("cargo:rustc-check-cfg=cfg(fbsd14)");
    println!("cargo:rustc-check-cfg=cfg(qemu)");

SteveLauC avatar May 05 '24 11:05 SteveLauC