Steve Dunn

Results 242 comments of Steve Dunn

I'm not sure if those failures are related to my change, but anyone more familiar with them please correct me if I'm wrong.

Thanks for the feedback. Looking at it again after a couple of months, it doesn't look as appealing as it did initially.

The example above won't work as-is, but something similar should make registering everything in an assembly easier.

Just looked at this again and there isn't a common `IVogen` type that would be suitable as a base interface for **all** value objects. So there's no way to represent...

> Just some thoughts... > > If the analyzer is applied to all linq queries regardless of their usage, it could break other people's code where they have non-EF queries....

> > When we get to the where clause, the type is just an IQueryable?. The DbSet typing has been lost due to the fluent chaining. > > I would...

> It's looking like a good start :) > > ![image](https://private-user-images.githubusercontent.com/234581/378601915-59b11f9a-1196-4d68-ac5d-ed8fb10356c3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mjk1NDgwOTAsIm5iZiI6MTcyOTU0Nzc5MCwicGF0aCI6Ii8yMzQ1ODEvMzc4NjAxOTE1LTU5YjExZjlhLTExOTYtNGQ2OC1hYzVkLWVkOGZiMTAzNTZjMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMDIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTAyMVQyMTU2MzBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kNzVkNzFiOTg0MzBlNTkzZTEzZGM2Yjc5NzM1NzJlNzk4ZmYyYWEyY2ExNzczNTQ3MzZiMDc0YzNkZDgwZWUyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.uzyofMpSbqEasx4lQ0WEkEukaU0yl66q6wViTSAJG2s) > > Both line 127 and 130 in the screenshot are detected as problems. > > The last approach...

I can get it to work for: ```csharp var step1 = context.Entities; var step2 = step1.Where(e => e.Id == id); ``` But, I can't get it to work for the...

Apparently, `SymbolFinder` isn't available to analysers. There's 'data flow analysis', but there's not much documentation on it, and the stuff that there is, I'm too stupid to understand! :)

I spent a fair amount of time trying to get the analyzer to spot the violation on the last line. ```csharp using var ctx = new DbContext(); DbSet step1 =...