Stephan T. Lavavej comments

Results 354 comments of


                                            Stephan T. Lavavej

trafficstars

Should we require SSE2?

> If the compiler and the CRT supports a mode, why would STL silently break? There's some precedent - we dropped XP/Vista (the compiler and CRT don't care the way...

Should we require SSE2?

We talked about this at the weekly maintainer meeting and are in favor of requiring SSE2 unconditionally. Note that this will require very minor internal build system changes to mirror...

It appears that the internal build system is globally setting `ClArchx86` to `IA32` in `src/tools/Microsoft.DevDiv.Native.targets`. This takes effect only when `` and is otherwise ignored. A project can set `SSE2`,...

Should we require SSE2?

Blocked by VSO-1952930 "x86 `/O2 /arch:SSE2` silent bad codegen in vectorized `std::min_element` for `int64_t`". This repros with VS 2022 17.9 Preview 5 x86 as soon as I remove `/arch:IA32` from...

Should we require SSE2?

I basically duplicated #3118 with somewhat different discussion. :joy_cat:

`<filesystem>`: compiler error using `directory_iterator`/`recursive_directory_iterator` inside a struct/class with modules

FYI @cdacamar this looks like a compiler bug.

`<filesystem>`: compiler error using `directory_iterator`/`recursive_directory_iterator` inside a struct/class with modules

I observe that this works if `broken_iter.ixx` says `import std;`.

`<filesystem>`: compiler error using `directory_iterator`/`recursive_directory_iterator` inside a struct/class with modules

Does this still repro with VS 2022 17.10 or later? I improved the STL so that include-before-import (*but not the other order*) works, with #4154 in VS 2022 17.10.