Stephan T. Lavavej comments

Results 353 comments of


                                            Stephan T. Lavavej

trafficstars

Upgradation

I'm not sure how that could save time, and it sounds like it would take work to maintain. I'd say I'm not very interested although I wouldn't reject the idea...

coreutils is relentlessly hostile to MinGW

I'm replacing it with https://github.com/uutils/coreutils which I was able to successfully build.

mingw-w64 7.0.0 linker errors caused by _FORTIFY_SOURCE

No longer repros with GCC 13.2.0 and mingw-w64 11.0.1.

grep 3.7 crashes without `-P`

I'm still not sure what happened here - I still repro it with grep 3.7 - but it appears to be fixed in grep 3.11.

`<algorithm>`: `ranges::inplace_merge` accidentally constructed `remove_cvref_t<iter_rvalue_reference_t <I>>`

Agreed. As in https://github.com/microsoft/STL/issues/4102#issuecomment-1769421279 this also indicates missing test coverage.

Avoid using MSVC-internal `_STRINGIZE`

Yes, I renamed them to consistently follow the Standard's rules for reserved identifiers, and to make it easier to verify that there are no remaining dependencies on microsoft/STL's removed macro.

[MSVC] Taichi failed with error G030630B7: static assertion failed: Unexpected size

Note that this involves https://github.com/microsoft/STL/pull/4591 , a very recent change to MSVC's STL. To reproduce this, you'll either need to build and consume our open-source STL, or wait for VS...

[Clang] Implement CWG2518 - static_assert(false)

We've verified that your patch fixes Root with our in-development compiler and STL, thanks!

<filesystem>: std::filesystem::exists fails when testing path naming unix socket

We talked about this at the weekly maintainer meeting. Nicole debugged into this and says that the problem is happening here: https://github.com/microsoft/STL/blob/f362f7d7bea87bd199c927a89718e929ed89b187/stl/src/filesystem.cpp#L910-L918 This is where `__std_fs_get_stats()` calls `CreateFileW()` (via `_Fs_file`)....