Stephan Schroevers

Results 203 comments of Stephan Schroevers

> Would it be useful to just disable this entire check for third-party users? Hmm, that would be a shame, as for actual member names I so far have never...

@graememorgan I see that `MemberName` was renamed to `IdentifierName` in 4f630fc668d107b7801281ce527e1a83a782dc1b. Should I therefore close this issue, or are there plans to e.g. implement an allowlist for cases such as...

> I'd be happy to accept a PR to flag class checking though. > [..] > I think I share your view that classes are somehow different though, but I...

Closing issue, as #4646 was merged. Tnx for the quick review @cushon!

@cushon this one was tricky! First to debug, then to find a (hacky...) workaround. It's a shame that we can't use `multiReleaseOutput`, as that would likely have avoided these shenanigans....

Added another commit to apply the `Elements` change. One issue I just identified: with my change `mvn clean install -DskipTests=true && mvn test -e` still doesn't fully work when building...

Alternatively, perhaps would-be-removed comments could be prepended to the replacement code. (This will in some cases yield misplaced/misleading/incorrect comments, but it would be handy i.c.w. patch mode.)

CC @rickie and @chamil-prabodha; this question relates to the discussion in #1474; in particular https://github.com/google/error-prone/pull/1474#issuecomment-1370633206 :)

@delanym the latest release is 2.18.0. For me the rule does work, and there are [tests](https://github.com/google/error-prone/blob/b80fcaf00a7bd0702f78a536b84ac0fa1407d657/core/src/test/java/com/google/errorprone/bugpatterns/javadoc/InvalidThrowsTest.java). Are you looking for [CheckedExceptionNotThrown](https://errorprone.info/bugpattern/CheckedExceptionNotThrown) instead? If not, please provide a [minimal reproducible example](https://en.wikipedia.org/wiki/Minimal_reproducible_example).

@delanym asking this kind of open-ended question without providing details is not helpful. You'll get better support if you spend time providing a minimal reproducible example.