Stefano Pigozzi

Results 78 comments of Stefano Pigozzi

> For example, what does a None value for Song.featured_video mean? Does it mean the Song had no featured video, or it just wasn't in the request dict? That's why...

@Allerter I've done as you asked. I checked, and confirm that `search_artists` isn't affected by this bug. (I found a few unused statements that I will probably fix in a...

> Useless plugin. Why don't you fix it yourself?

I seem to have encountered the same problem: ![Sync fails while the all tasks are successful](https://user-images.githubusercontent.com/1540885/156863085-5055b45a-1fc2-43ca-a7ee-35dfddc3667b.png "Sync fails while the all tasks are successful") The repository in which I am...

I _think_ the problem is in the dependency chain: `@rollup/pluginutils` < `rollup-plugin-replace` < `workbox-webpack-plugin` < `preact-cli`

More in detail, I think the original "destination" URL is lost while performing a Omniauth login, and that all Omniauth logins automatically redirect to the home page. For example, visiting...

I suspect (but I'm not sure, since I've never used Rails before) that the problematic line of code is the following: https://github.com/mastodon/mastodon/blob/54bb659ad14fda8d3427752d2c99716420997d6e/app/controllers/auth/omniauth_callbacks_controller.rb#L20

Specifically, by using `sign_in_and_redirect`, the user is redirected to the "after sign-in page": https://github.com/heartcombo/devise/blob/8593801130f2df94a50863b5db535c272b00efe1/lib/devise/controllers/helpers.rb#L240 Which supports redirecting to a stored location: https://github.com/heartcombo/devise/blob/8593801130f2df94a50863b5db535c272b00efe1/lib/devise/controllers/helpers.rb#L216 So perhaps the location is never stored anywhere...?

Here's what I think is the source of the problem! https://github.com/mastodon/mastodon/blob/54bb659ad14fda8d3427752d2c99716420997d6e/app/controllers/auth/omniauth_callbacks_controller.rb#L33-L39

Nope, the fix didn't work. I'm not sure what else to try, I've been messing around with Omniauth all night, and I haven't been able to figure out anything else.