Peter Steffey

Results 182 comments of Peter Steffey

Why do you think this should be done in the core library instead of in a wrapper in your project?

@TPXP Due to how long it's been since I've worked on this, I can't even spin up my expo test project anymore, which I would need to run regression tests....

Do you mean that you want, for example, the open animation to have a different `animationConfig` than the close animation?

Got it, that makes sense. I'm not sure the best approach, but feel free to propose a PR with whatever method you find simplest and I will review.

I'm not able to work on this library right now. I may consider and test PRs, but will not be doing any debugging myself.

@rxliuli 's fixed released as 1.5.6, please test and remove your NPM package if this works. @SherifMega Can you provide more details on what you mean by screen? Are you...

This library is no longer maintained, but my fork of it has this feature already, allowing you to pass in any custom styles you would like. Check out https://github.com/SteffeyDev/react-native-popover-view

I also have forked and updated this library so that it works with the latest react native, and have a very similar API to the Popover in this repository: https://github.com/SteffeyDev/react-native-popover-view

I referenced this in the issue I raised, it has to do with the fact that setting the style causes recursion because of the way the style variable is set...

I'm seeing the same on 5.1.1, have to use "Recompile from scratch" after opening each document, after which it compiles and runs normally