Steffen Deusch

Results 224 comments of Steffen Deusch

I changed to callbacks to `beforeEach(from, to)` and `afterEach(from, to)`. Both parameters get passed the full href string and both can now return promises as well. Next step: add some...

Still missing: documentation

You can have a look at view transitions in action: just run `npm run e2e:server` and visit http://localhost:4000/navigation/a. On Page B you can test the form confirmation.

Docs done, ready for review and final touches.

That’s a very good point. I’ll try to adapt the API to incorporate the history state.

@breunigs have a look at https://github.com/phoenixframework/phoenix_live_view/pull/3051/commits/03fb8bf230626dc36640398342ddb3861b2b828e

@breunigs this is sadly a limitation of the history API. When you navigate to a new page, we save the userData in the "old" history state. The history is like...

I'll need to think about this a little more.

> If so, then I presume something like https://caniuse.com/mdn-api_navigation_navigate_event would do the trick, but that API isn't even usable in all modern browsers, let alone the ancient ones LV still...

@bcardarella yes, actually LiveView already uses the history state for storing the scroll position. I also tried to expose the history state in the more generic navigation guard API proposed...