Steffen Deusch comments

Results 224 comments of


                                            Steffen Deusch

JS options when connecting the socket should be documented, and general JS documentation improvements

Hi @srcrip, those are all very valid points you're raising here. Unfortunately the tl;dr is: neither Chris nor I actively do Typescript, therefore anything related to types isn't something we're...

Rework EntryUploader to use promises intead of setTimeout

I assume we could add a `acceptsBlobs` property to the channel and then we can check in LiveView if it exists. LiveView would then need to keep both code paths...

Missing `phx-update="stream"` attribute should be detectable and error out in tests

I think I also had code for LiveViewTest somewhere, but I can't find it right now. It's definitely possible. For making it more visible, I've been thinking more than once...

.formatter.exs does not export formatting rules

Right, currently all the formatter rules are defined in Phoenix only: https://github.com/phoenixframework/phoenix/blob/9490f091a90a9050bca04f86a9ad2b7d486b1f87/.formatter.exs#L66-L96 I guess we could duplicate the rules?

.formatter.exs does not export formatting rules

@josevalim do you have opinions on this?

Feature: Allow error reason to get to the server

Related: https://github.com/phoenixframework/phoenix_live_view/issues/2502 https://github.com/phoenixframework/phoenix_live_view/issues/1478#issuecomment-853758197

Allow inputs to opt out from unused tracking

> But now I'm wondering: is there a way to disable the appending of _unused_ fields? I have some plain forms not bound to any entity, which I use for...

Allow inputs to opt out from unused tracking

opinions? @chrismccord @josevalim

Allow inputs to opt out from unused tracking

@leepage87 how do you set this cookie? You should probably filter the parameters there.

Testing for errors raised in a liveview

Well, there is "some way", but it's indeed not very nice: ```elixir Application.put_env(:phoenix, Example.Endpoint, http: [ip: {127, 0, 0, 1}, port: 5001], server: true, live_view: [signing_salt: "aaaaaaaa"], secret_key_base: String.duplicate("a", 64)...