StefanThoma

Results 46 comments of StefanThoma

> near(1 * 10^-8, 2 * 10^-8) @bundfussr Same is TRUE for `all.equal()` in this example: ``` > all.equal(10^-8, 2 * 10^-8) [1] TRUE ```

Very happy for snapshot tests. @bms63 what did you have in mind?

I would agree with removing AVALC from the ADVS vignette: https://pharmaverse.github.io/admiral/articles/bds_finding.html Also, I would remove it from the template, but would leave the part commented out probably, so if there...

@bms63 yes I think so, depending on whether everything works out :)

Notes: ADLB does not need to be adjusted, as COLOR is non numeric in AVALC ADEG does not need to be adjusted, as some values are "NORMAL" in AVALC. However,...

I guess my question is; Should AVALC (e.g. in ADEG) look more like this: ![Screenshot 2024-05-29 at 10 26 12](https://github.com/pharmaverse/admiral/assets/40463122/676e3f61-a179-47cd-a8a0-a43f936b7b13) Or more like this: ![Screenshot 2024-05-29 at 10 30 23](https://github.com/pharmaverse/admiral/assets/40463122/16099e56-fe1f-446d-943f-a240d24ea6c5)

> > I guess my question is; Should AVALC (e.g. in ADEG) look more like this: > > > > > > ![Screenshot 2024-05-29 at 10 26 12](https://private-user-images.githubusercontent.com/40463122/334720250-676e3f61-a179-47cd-a8a0-a43f936b7b13.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTY5ODQxNzgsIm5iZiI6MTcxNjk4Mzg3OCwicGF0aCI6Ii80MDQ2MzEyMi8zMzQ3MjAyNTAtNjc2ZTNmNjEtYTE3OS00N2NkLWE4YTAtYTQzZjkzNmI3YjEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTI5VDExNTc1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcwYzI2ZTE5NTA1NzQ4M2JmNTRhMmIzZTA4ZTYxNTlmNTFlNDJiYzU0Y2JkNTI4MTA2OTNhZTBkYjMyODQ3OWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.0uRqjR64xndjiVy9ERokLs-mjJbLSP3DZf06-6kDt6o) > >...

> If you're referring to the 2 screenshots that Stefan originally included (I'm not able to see the ones in the more recent posts), neither is correct, according to the...

> Hi Stefan, > > If the "NA" are intended to represent blanks, that's fine. When EGSTRESC=NORMAL, I'd expect AVALC to be "NORMAL", and AVAL to be left missing, unless...