Stef Heyenrath

Results 713 comments of Stef Heyenrath

I think some changes can be done to **WireMockProtoFileResolver**: - Use `GetInvalidPathChars` instead of `GetInvalidFileNameChars` - only strip the comment characters and some spaces and keep the rest This would...

The last one is the most user friendly I guess. The `ProtoDefinitionHelper.FromDirectory(...)` method returns a dictionary which should be usable in WireMock. However, this needs a lot a changes. So...

> On a possibly unrelated note, would it be possible to get access to the deserialized proto instance through the log entries? I'm using this to assert the received messages...

> That would be an acceptable compromise I'd say 👍 The comments themselves are harmless and as long as you are not inspecting the in-memory data yourself, there should be...

> > > On a possibly unrelated note, would it be possible to get access to the deserialized proto instance through the log entries? I'm using this to assert the...

> I mean the request message. When I make a gRPC request to WireMock, I don't see the JSON unless I set the transformer on the response. OK, in that...

Thanks for testing. 1. imports in the proto files indeed should use a forward slash (`/`), this is fixed, please test the latest preview. 2. Currently, the first file is...

## :one: I've changed the code, so that now you can call this once (same as you've done in your example): ``` c# var protoDefinitionData = ProtoDefinitionHelper.FromDirectory(directory); ``` And then...

Currently, I need the id. Because currently I need the distinction between the protobuf file(sets). For example when you want to use opentelemetry AND greet, you need to define 2...

@ocombe Just double check about your previous comment: while testing this bug, it seems that for both the `pipe` and also the `directive`, you still have to refresh/update the full...