Steven Allen comments

Results 1846 comments of


                                            Steven Allen

Choose a writable temp dir please

@hunger please ask the cargo team for an override. That's not something this library can help with (and not related to this issue).

Builder option to avoid cleanup on Drop

Sounds like a good feature.

Depend on remove_dir_all 0.6

Note: This is currently blocked because `remove_all_dirs` 0.6+ adds a dependency on rayon, and I'm strongly against having a temporary file library launch new threads.

Update `Builder` (or `create_helper`) to check that the supplied `prefix` and `suffix` don't contain `/`

So, filtering `\0` shouldn't be necessary as the OS will do that. Really, we can't reasonably build a blacklist for every OS so we might as well delegate. In retrospect,...

Update `Builder` (or `create_helper`) to check that the supplied `prefix` and `suffix` don't contain `/`

I agree but `Builder::new().prefix("foo/bar").tempfile()?` is valid and potentially useful so I'm worried someone is already using it. However, I really do agree that we _shouldn't_ allow that and users should...

Add parameter for not restricting access to the named tempfile

Sounds reasonable. However, I'd rather accept an `std::fs::Permissions` object as that's more general and cross platform. Would that work?

Add parameter for not restricting access to the named tempfile

Gah. I keep not posting my replies. You're absolutely correct, that's unfortunate.

Add parameter for not restricting access to the named tempfile

So, thinking about this, I'm fine with this approach. I'd rather have a more general approach but... the only API this touches is the builder. Given that, I'm fine going...

Add parameter for not restricting access to the named tempfile

This is still going to need Windows and, preferably, directory support.

Indenting / nesting content macro

Unfortunately, whitespace can have meaning in HTML and horrorshow isn't smart enough (it's a macro) to know when it has meaning and when it doesn't. That means I can't really...