tempfile icon indicating copy to clipboard operation
tempfile copied to clipboard

Published 20 hours ago • verified publisher icon Stebalien

Depend on remove_dir_all 0.6

Open dvtomas opened this issue 3 years ago • 1 comments

I'm removing duplicate dependencies from my project, and remove_dir_all 0.5 (tempfile) vs 0.6 (others) is one of them

dvtomas avatar Oct 06 '20 14:10 dvtomas

Note: This is currently blocked because remove_all_dirs 0.6+ adds a dependency on rayon, and I'm strongly against having a temporary file library launch new threads.

Stebalien avatar May 18 '21 15:05 Stebalien

Is remove_dir_all still needed? Cargo recently removed it and std::fs::remove_dir_all shows better performance: https://github.com/rust-lang/cargo/pull/11333

messense avatar Nov 05 '22 09:11 messense

Resolved in #207. Also, remove_dir_all no longer requires rayon.

Xaeroxe avatar Feb 24 '23 18:02 Xaeroxe

By the way, there is a race condition in old (<0.8.0) versions of the remove_dir_all library, so it would be nice to either update or remove this crate.

stanislav-tkach avatar Feb 24 '23 19:02 stanislav-tkach

Changed my mind, switched to removing it in #208

Xaeroxe avatar Feb 24 '23 20:02 Xaeroxe

Was https://github.com/rust-lang/rust/issues/29497 worked around?

adumbidiot avatar Feb 26 '23 07:02 adumbidiot