Cyrille Bollu

Results 53 comments of Cyrille Bollu

I don't think the drone failure is due to my changes

> I think we should add the sass commands as a postbuild step instead ? Makefiles are arbitrary and not ideal imho I don't understand your comment :-(

> tested locally, while it does run those commands, there's another separate issue: in README we tell people to run "make build-js-production" and now that would include those commands. >...

Wow, I can't even find back my LDAP configuration on version 2.5 !?!

and I can't log using LDAP anymore :-(

nevermind my last comment, it's just that my change in `backend/AUTH/auth.php` got erased by the upgrade. Though, it looks like I still cannot find back the LDAP configuration: ![image](https://user-images.githubusercontent.com/8179031/44846379-767c0300-ac50-11e8-8d17-fc4b3c4e0d36.png)

aaaahhh, thanks @tiagobortolini Again, something that got changed due to the upgrade to 2.5

There's some specific code related to the ´memberOf´ attribute in function `search_on_loginnt` in file `backend/AUTH/methode/ldap.php`: ```php // if the extra attributes are there, save them as well if ($info[0][$f1_name][0] !=...

Then, later in file `backend/identity/methode/ldap.php`, this value is user to assign role as follow: ```php if ($f1_value != '') { //NEW CODE BELOW //FIXME: casing? -> 'memberOf' if ($f1_name ==...

Unfortunately, I can't test here as we are using another attribute than `memberOf` and it just works fine.