Jonathan Coates

Results 565 comments of Jonathan Coates

I'd say only the middle is legal: the first is more of an API rather than data and the last isn't a table.

> It's worth noting that EMI actually supports "additional" mod ids in searching Oh, that is neat! Just to double check, this isn't exposed to the API right now -...

Moving this to the CC:Restitched repo, as this is a Fabric-specific bug. The chunk mixin should pass around the `LevelChunk` to avoid having to refetch it: https://github.com/cc-tweaked/cc-restitched/blob/41cff864c4d1cc36341b267fcdf569a002d96694/src/main/java/dan200/computercraft/fabric/mixin/MixinChunkMap.java#L49

Probably related to https://github.com/cc-tweaked/cc-restitched/issues/133?

This is pretty similar to #146, and I guess https://github.com/cc-tweaked/CC-Tweaked/issues/956 too. Really the best thing to do here is what we've done on the CC:T side and remove as many...

We currently do permission checks using two systems: - `MinecraftServer.isUnderSpawnProtection` - Patbox's Common Permission API FTB-Chunks however listens to Fabric API's block events, which we don't fire. We should fire...

Ideally it should be possible to infer `forgeRuntimeLibrary` automatically - the legacy classpath can just contain any dependency that doesn't contain a `mods.toml` or `FMLModType` in its `META-INF.mf`.

"non-mod classpath jars that get special treatment from Neo/Forge"

Oh gosh, thank you! Don't feel like you have to do this - I'm aware some of the code here is pretty nasty :). > The generated code has a...

Another case where this occurs is the following: ```lua do return(x)end ``` This will be much harder to fix. It's times like these I wish we had a zipper list...