Jonathan Hale
Jonathan Hale
Thanks for the review! I'll have time to apply the requested changes and split the changes from effects.h tomorrow evening CEST.
@kripken I applied the feedback and split off the changes to effects.h 👍 Opening a PR for that in a few moments, benchmarking a few alternatives to 10
@kripken Please consider the benchmark and analysis [here, on the other PR](https://github.com/WebAssembly/binaryen/pull/4885#issuecomment-1209527026) before merging this. While it's a net-positive, it does pessimize the code without the EffectsAnalyzer change, which seems...
I hastily refactored the function yesterday, avoiding the recursion, which fixes the issue here: ```js /** return a flat list containing all decendants @param [sortBy] {string} - "kind" @param [min]...
Same here! I think this is because gltf-pipeline only supports png or jpeg and therefore cannot handle the basis binary data or detect the format on it. (That has been...
@jtoy @ashconnell All signed :)
Would also be interested in this being merged :) For those who are here because of images not being moved when a row is inserted above, you can use: ~~~ruby...
From gitter to archive here: > It appears that in addition to the Skin Data, we will need to import some form of "Skin" or "Skeleton", which requires extension of...
@mosra I did actually try for 15 Minutes, but because they package their prebuilt binaries with an additional folder inside the zip, I got stuck trying to unpack the zip...