magnum-plugins icon indicating copy to clipboard operation
magnum-plugins copied to clipboard

modules: Fix FindWebP.cmake for windows

Open Squareys opened this issue 3 years ago • 2 comments

Hi @mosra !

This is a very simple one, the precompiled binaries on windows are named libwebp.lib and similar, and on Windows, NAMES webp is therefore not enough, since windows has empty CMAKE_STATIC_LIBRARY_PREFIX.

Best, Jonathan

Squareys avatar Jul 13 '22 19:07 Squareys

Ah lol once again Google's "buildsystem" that doesn't care about platform differences and uses a lib prefix everywhere. Thanks!

Annoying request: since you say there's a prebuilt library, could you make this be built on AppVeyor as well? (I won't get mad if you refuse.)

mosra avatar Jul 13 '22 19:07 mosra

@mosra I did actually try for 15 Minutes, but because they package their prebuilt binaries with an additional folder inside the zip, I got stuck trying to unpack the zip such that the include, lib and bin would get merged into dependencies. Currently unfortunately that meat I had to give up, too much going on atm :/

Squareys avatar Jul 14 '22 14:07 Squareys

Merged as 36c8af44d2b6f0d31a7f1f89c8222bc07a920aa8, and in e28d05b6a6e1ecdddad7926cdfe2a6548aed14bf I added the Windows CI build to have this covered there as well. Wasn't too bad in the end :P

mosra avatar Sep 18 '22 22:09 mosra