Michael Prentice

Results 398 comments of Michael Prentice

I wanted to find a Protractor issue for this, since it's more of an issue there than with AngularJS itself. Related issues - Safari security fix broke `window.name` usage here:...

From the Firefox bug tracker: > using the pref is not really an option given that it was only added for rollout purposes. So it looks like that work-around may...

Chromium is getting closer to shipping this in a beta: https://groups.google.com/a/chromium.org/g/blink-dev/c/86VeIi5sZzc/m/CVJadvpqAQAJ Do we have any plans for working around this?

This verifies #17117 as there are many `Failed: Error while running testForAngular: Timed out after 30000 ms` in the e2e tests. It doesn't look like we can test against and...

Please change `Fixes: #11610` to `Fixes #11610` in the commit message so that our changelog parsing will work properly.

Just bumping this to get your attention 😄 It would be nice to get this into `1.1.14` which may go out in the next week or two.

Just a reminder that this only needs some minor tweaks before we can get it in.

@codymikol thank you for rebasing this. Do you think that you will have time to address the review feedback soon?