material icon indicating copy to clipboard operation
material copied to clipboard

Published 20 hours ago • verified publisher icon angular

docs($mdMenu): add documentation for $mdMenu

Open codymikol opened this issue 6 years ago • 7 comments

currently there is no documentation.

Fixes: #11610

PR Checklist

Please check that your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines
  • [x] Tests for the changes have been added or this is not a bug fix / enhancement
  • [x] Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[x] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Docs for $mdMenu are missing

Issue Number: #11610

What is the new behavior?

Added documentatiion

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

codymikol avatar Feb 22 '19 02:02 codymikol

Please change Fixes: #11610 to Fixes #11610 in the commit message so that our changelog parsing will work properly.

Splaktar avatar Feb 26 '19 19:02 Splaktar

Just bumping this to get your attention 😄 It would be nice to get this into 1.1.14 which may go out in the next week or two.

Splaktar avatar Mar 13 '19 21:03 Splaktar

I'll try to make these changes soon 🐔

codymikol avatar Mar 14 '19 01:03 codymikol

I took a bit of a break from writing software over the past few weeks, I'll try and take a look at this over this coming week. 🐔

codymikol avatar Apr 20 '19 17:04 codymikol

Just a reminder that this only needs some minor tweaks before we can get it in.

Splaktar avatar May 10 '19 19:05 Splaktar

@codymikol thank you for rebasing this. Do you think that you will have time to address the review feedback soon?

Splaktar avatar Sep 30 '19 23:09 Splaktar

I finally had some time and after looking at it I realized that I'm pretty much documenting the directive usage in the service docs. I spent some time trying to wrap my head around using the actual service itself and it is definitely a different process entirely. Hopefully I'll be able to take some time and play around with the actual service in a codepen this week until I feel confident enough to write the documentation for its usage.

codymikol avatar Oct 01 '19 02:10 codymikol