SpacePlushy comments

Results 4 comments of


                                            SpacePlushy

Warning when extending from own env

I've identified and fixed this issue! The problem was in the `walk_options` method in `platformio/project/config.py` - it didn't check for circular dependencies when processing extends directives. The fix adds cycle...

Undefines in build_flags don't work if there's a space after -U

I'd like to work on this issue. I've identified the root cause: when `-U MACRO` is written with a space, SCons' `ParseFlags()` splits it into two separate items in `CCFLAGS`:...

Unit test runner shows PASSED in summary when there are failing tests

I've identified and fixed the issue! **Root Cause:** In `platformio/test/cli.py` line 201, the `print_suite_footer` function was hardcoding "PASSED" for any non-error test status. This caused SKIPPED test suites to incorrectly...

Fix: Handle -U flags with spaces in build_flags

**Note on testing:** In my initial comment on #5237, I mentioned including tests with this PR. After exploring the codebase, I noticed there aren't existing unit tests for the builder...