Results 135 comments of Jason Parraga

https://github.com/flyteorg/flyte/pull/5460 should make this obsolete.

> A few small suggestions, otherwise LGTM! Thanks for the review!

> Thanks for confirming @kcon-stackav. Would you be able to share some of the tls settings of the nginx config you're using? (e.g. `ssl_protocols`, `ssl_ciphers`, etc.) and also the `openssl`...

This appears to be related to some custom decoding which turns slices into maps: https://github.com/flyteorg/flyte/blob/master/flytestdlib/config/viper/viper.go#L177-L203 Fixing this includes all the key/values but unfortunately the keys are lowercased.

Instead of dumping more time into this I ended up just forcing the old version of viper. `replace github.com/spf13/viper v1.18.2 => github.com/spf13/viper v1.11.0`

> Hi @Sovietaced, I can't reproduce the issue just after upgrading the viper version. Is there any other package had been changed? > > go version: `go version go1.22.8 darwin/arm64`....

> I just run the `go get github.com/spf13/[email protected]`. > > > > Then this is the diff after upgrading the viper: https://github.com/Terryhung/flyte/commit/6a440cb57d3509eed8d8bf80da6563f6f9eeb6bb. > > > > I found the viper...

Without looking to deeply at this I feel that the plugin manager code probably shouldn't be doing exceptional work for a third party Kubernetes scheduler. My intuition is that you...

> All the changes introduced in this PR are gated behind a configuration flag, which is disabled by default. This ensures that the plugin manager will not perform this functionality...

> @fg91 @Sovietaced Thanks for the insights. I understand your concern. I’m wondering if there are any actionable steps you’d suggest I take to help move the PR forward? I...