flyte icon indicating copy to clipboard operation
flyte copied to clipboard

Update FlyterPropeller config to working config for flyte agent

Open Sovietaced opened this issue 1 year ago • 1 comments

This pull request updates the flyte agent documentation to include working FlytePropeller configurations when running a custom agent/task. The previous configuration did not configure the agent service endpoint for propeller and attempts to run custom tasks would result in the following log messages. This also formats the YAML to 2 space indent.

❯ kubectl logs flytepropeller-5559db6f4d-bgpr7 -f | grep armada                                                                                                                                                            
{"json":{"exec_id":"f6bf36697f1a84994907","node":"examplesayhello","ns":"flytesnacks-development","res_ver":"32767965","routine":"worker-0","tasktype":"armada","wf":"flytesnacks:development:.flytegen.example.say_hello"},"level":"warning","msg":"No plugin found for Handler-type [armada], defaulting to [container]","ts":"2024-05-16T01:07:14Z"}
{"json":{"exec_id":"f6bf36697f1a84994907","node":"examplesayhello","ns":"flytesnacks-development","res_ver":"32767966","routine":"worker-0","tasktype":"armada","wf":"flytesnacks:development:.flytegen.example.say_hello"},"level":"warning","msg":"No plugin found for Handler-type [armada], defaulting to [container]","ts":"2024-05-16T01:07:14Z"}

Sovietaced avatar May 21 '24 16:05 Sovietaced

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.10%. Comparing base (458da5c) to head (6190d59). Report is 164 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5401      +/-   ##
==========================================
+ Coverage   61.07%   61.10%   +0.02%     
==========================================
  Files         793      793              
  Lines       51210    51156      -54     
==========================================
- Hits        31275    31257      -18     
+ Misses      17059    17027      -32     
+ Partials     2876     2872       -4     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.31% <ø> (+0.33%) :arrow_up:
unittests-flyteidl 79.30% <ø> (+0.25%) :arrow_up:
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 21 '24 17:05 codecov[bot]

https://github.com/flyteorg/flyte/pull/5460 should make this obsolete.

Sovietaced avatar Jun 12 '24 05:06 Sovietaced