Sourabh Badhya

Results 10 comments of Sourabh Badhya

I would consider running a flaky test Jenkins job for determining whether the fix will resolve the issue. Please consider using this Jenkins job - https://ci.hive.apache.org/blue/organizations/jenkins/hive-flaky-check/activity @ayushtkn @zabetak @deniskuzZ I...

`equals()` is used to check the object content, `==` does a comparision on the object reference. Using `equals()` is the right programming paradigm. I did a small test for confirming...

@dk2k Please rebase your PR for the tests to pass.

@dk2k There is a qtest which is failing - windowing_udaf.q due to this change. Please evaluate whether modifying the corresponding q.out file is OK here. https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5743/6/tests

@dk2k Please merge with master branch due to recent Calcite upgrade.

Hi @armitage420. Thank you for your efforts. I have been busy, I will try to review it this week. If this is urgent, feel free to ping other committers as...

@deniskuzZ / @ayushtkn can you please take a look as well?

@armitage420 Spell checking seems to fail, can you please check.

Cool, I am merging this, since no one has an objection for a very long time.