Sophist
Sophist
> First off: I like the general idea of allowing the user to select a different result if multiple matches are found. Me too. > I think in general using...
The time since last message before slowdown and the rate after slowdown are both new options set in config,js.
I note that we have Travis tests, however they run both Py2 and Py3 tests, and plugins may not work correctly on both. So we need to run Travis tests...
P.S. Travis also runs Py3.4 tests - not sure why as Py3,4 is not supported for Picard v2.
> Code-wise this looks fine for me. But I wonder if we need another simple conversion plugin like this which operates on a limited set of fields for a very...
This is an interesting PR. But as far as I can see, it will cythonize if it possibly can. Given the significance of this, can I suggest that you run...
@phw Philipp - I agree with you that genres needs an overhaul (see [PICARD-2054](https://tickets.metabrainz.org/browse/PICARD-2054)). As and when Picard has the supporting functionality, then plugins like this and lastFm can hook...
Hmm ... should we use singular "genre" or plural "genres"? I am in favour of having three variables holding the genre data specific to artist, release and track **and also**...
On reflection, I think that genre plugins should always add genres to any existing list rather than replace them.
See also [lastFm+ v2 PR](https://github.com/metabrainz/picard-plugins/pull/170).