Sonia

Results 18 comments of Sonia

@AlanBateman @wolfseifert Thanks for the comments! Just wanted to note that I tried out https://github.com/openjdk/jdk/pull/18753 and the issue is not resolved.

hi all, thanks for the comments! Happy to make the updates based on the feedback. However, could someone please advice if we are proceeding with this PR or https://github.com/openjdk/jdk/pull/18753? As...

@lahodaj > I would suggest to take the test from 18753 though - doing a change like this without a test may lead to hard-to-find regressions in the future. (Note...

I made the updates based on feedback. Just a few things to note: * I included the test case from https://github.com/openjdk/jdk/pull/18753 and verified it passes with this PR. * Replacing...

Hi @mlchung, thanks for the feedback! I’ve pushed the updates. Just a question about ```NULL_CHECK0```. ```NULL_CHECK0``` reports the error message and then the exception is described in ```CHECK_EXCEPTION_LEAVE```. This results...

Hi @jaikiran, the failures were related to my change. I forgot to check the invocation failed and only trigger ```CHECK_EXCEPTION_LEAVE``` then. I have pushed an update that should fix the...

FYI, I've also re-run all added test cases since making the latest changes and they pass.

Just noting, I don't think the GHA failures are related to my patch.

> This may be food for another RFE, to keep this patch minimal. But a good solution, to me, would be like this: > > * have the same logic...