8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used

[SoniaZaldana]

Hi all,

This PR contains a backport of 43c6f0b5880899b797fab2f851bd35be1c342439.

Patch is not clean. Test won't build in 11 because it can't find import jdk.internal.util.OperatingSystem.

This class was introduced in 21 as part of JDK-8303485.

I've worked around that by removing the dependency to that utility function and checking the operating system with test/lib/jdk/test/lib/Platform.java.

Testing:

• [x] Modified test case passes

Thanks!

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8326591 needs maintainer approval

Issue

• JDK-8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2679/head:pull/2679
$ git checkout pull/2679

Update a local copy of the PR:
$ git checkout pull/2679
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2679/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2679

View PR using the GUI difftool:
$ git pr show -t 2679

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2679.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back szaldana! A progress list of the required criteria for merging this PR into pr/2609 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@SoniaZaldana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 1d6965fd4eba8c22589f1833e3a1639f05ada771: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError
• 2a804f54aa8f921942e98557770446b06c19c1aa: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
• ece9b2cd3ba498d36832bc168237c3d60ecb4d4a: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• 2ff4d4edfb5a069ac74cb65c974d5861e6147be6: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
• 59224f7ddfa9a874422f9c9ef3d5ccb211feb3ae: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
• 42f70422f10472aa67ca86bfbac25a5d5c314ec2: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
• 270f3cfb3da7ef15e5fbbc3ea1d0d7cd3e3cf802: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
• 4714685d6e4bfda3573ae82fa4bfc687460f4b75: 8328825: Google CAInterop test failures
• 6d3a41fec7a53cff7aa94641597328dca5e38d08: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
• 4b67c4ecd5a10a89397688b0c81a177729510863: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
• ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/137a8b9dcfaad4a96dfd22f57c759dfc4ea71f05...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mlbridge[bot]]

Webrevs

• 03: Full - Incremental (478026af)
• 02: Full - Incremental (a517e2ee)
• 01: Full - Incremental (857623ce)
• 00: Full (857623ce)

[openjdk-notifier[bot]]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout my-backport-8326591
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[amosshi]

Testing Machine: SAP nightlies passed on 2024-05-02

• Automated jtreg test: jtreg_jdk_tier1
• jdk/modules/etc/JmodExcludedFiles.java: SUCCESSFUL GitHub 📊⏲ - [221 msec]

[openjdk[bot]]

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[TheRealMDoerr]

This one is ready for integration.

[SoniaZaldana]

/integrate

[openjdk[bot]]

@SoniaZaldana Your change (at version 478026af5cae48d66afd5d602355477cdac64923) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk[bot]]

Going to push as commit b8ee2aa15ab538f5a0623b391e1c64e5e63e167a. Since your change was applied there have been 21 commits pushed to the master branch:

• 1d6965fd4eba8c22589f1833e3a1639f05ada771: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError
• 2a804f54aa8f921942e98557770446b06c19c1aa: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
• ece9b2cd3ba498d36832bc168237c3d60ecb4d4a: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• 2ff4d4edfb5a069ac74cb65c974d5861e6147be6: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
• 59224f7ddfa9a874422f9c9ef3d5ccb211feb3ae: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
• 42f70422f10472aa67ca86bfbac25a5d5c314ec2: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
• 270f3cfb3da7ef15e5fbbc3ea1d0d7cd3e3cf802: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
• 4714685d6e4bfda3573ae82fa4bfc687460f4b75: 8328825: Google CAInterop test failures
• 6d3a41fec7a53cff7aa94641597328dca5e38d08: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
• 4b67c4ecd5a10a89397688b0c81a177729510863: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
• ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/137a8b9dcfaad4a96dfd22f57c759dfc4ea71f05...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@TheRealMDoerr @SoniaZaldana Pushed as commit b8ee2aa15ab538f5a0623b391e1c64e5e63e167a.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.