Kirill Bulatov
Kirill Bulatov
Thank you for the explanations. It would save a lot of time on the decision-making if was put as a description in the PR. In this particular case, let's close...
Yes, or if you insist it's almost the same, I'd extract the common part and/or rename it into the "copy_external_files" or something.
If I'm not reviewing yet, can you guess if I have time or not?
Sorry, I am away for this week also, and expect to look at the PR early next week. Please ping anybody else if you want the review faster.
(also, the `Before` image seems to be wrong)
Ok, after the recent release, we have a week to get the feedback based on nightly builds and consider leaving or reverting this.
I cannot be sure as no feedback on the design was given, but personally interested in looking at how it looks, so can review the new PR. I could swear...
What is the language you're using? * Svelte https://github.com/zed-industries/zed/issues/16469 * Vue https://github.com/zed-industries/zed/issues/13769 are reported and have a workaround (maybe even a fix) ready.
That issue seems to mention permission issues with *.sh files, so not sure that the same fix applies — but I'll add that just in case too, thank you.
That is really odd, not related to the fix above then. Could you share settings.json, logs and, ideally, a project to repro things on? (or is it happening everywhere?)