zed icon indicating copy to clipboard operation
zed copied to clipboard

Add git awareness to file tab icons

Open nesrve opened this issue 1 year ago • 1 comments

Before: Screenshot 2024-08-22 at 15 58 22

After: Screenshot 2024-08-22 at 15 58 32

Release Notes:

  • N/A

nesrve avatar Aug 21 '24 22:08 nesrve

(also, the Before image seems to be wrong)

SomeoneToIgnore avatar Aug 23 '24 09:08 SomeoneToIgnore

Ok, after the recent release, we have a week to get the feedback based on nightly builds and consider leaving or reverting this.

SomeoneToIgnore avatar Aug 28 '24 22:08 SomeoneToIgnore

LGTM code-wise, let's wait for the design notes.

As a potential follow-up, we might consider the same approach for file_finder items. There are no icons and no git statuses there yet, maybe it's a good time to consider adding those too if @iamnbutler has an opinion?

i could work on this too and open a separate pr, if it's something that's wanted

ghost avatar Aug 28 '24 23:08 ghost

I cannot be sure as no feedback on the design was given, but personally interested in looking at how it looks, so can review the new PR.

I could swear there was an issue for this, but failed to find it now.

SomeoneToIgnore avatar Aug 29 '24 09:08 SomeoneToIgnore