Somayeh Saghamanesh

Results 10 comments of Somayeh Saghamanesh

I haven't tried SSRB for our purposes. Does it work with generic geometries as well? Can I rebase and then continue in the same PR?

But I thought I had rebased and removed that commit. Are you sure it doesn't belong to another branch? On Wed, Sep 4, 2024, 17:53 Kris Thielemans ***@***.***> wrote: >...

I did several rebase and looks something went wrong in between. I'll take care of this. On Wed, Sep 4, 2024, 18:13 Kris Thielemans ***@***.***> wrote: > clearly not. 5000+...

I think the git problem is fixed now.

Yes, I have already followed it in PR #1508, changed two classes to be consistent with ProjDataInfo.cxx.

Just not sure why 8 tests (including FBP, OSMAPOSL, etc) are failed after these changes. Haven't gone through them yet. Any comment is appreciated.

On Wed, Nov 12, 2025 at 2:17 AM Kris Thielemans ***@***.***> wrote: > ***@***.**** requested changes on this pull request. > > sorry for delay! > Thanks for your note....

I have tested this before and that's why I say it doesn't work at least for generic geometry. I get below error: "" ERROR: The tangential_pos range (-90 to 89)...

Hi. sorry for my late response, I was away. Regarding SSRB not working for trimming projections, as you can see from the message, it is related to the same problem...

I will go through the changes and let you know.