­Sollace

No bots/spam please. @DHaussermann If I see more of that I'm going to have to start locking threads.

> The module name should be `fabric-model-events-v1`. > > https://github.com/FabricMC/fabric/blob/a462da68c68e109073526be5dd1ae8803e642435/CONTRIBUTING.md?plain=1#L289-L291 The thing you quoted appears to disagree...?

> > Event modules should have the `-events` suffix instead. > > This seems to be an event module? Hm okay

Something I'd like some feedback on: 1. Thread safety in `ModelRenderContext.java`. Since this is entirely connected to rendering, I would presume this is always being accessed from the same thread....

Making a note: https://github.com/Glitchfiend/SereneSeasons/tree/1.21/common/src/main/resources/data/sereneseasons/tags/block Relevant tags are: `sereneseasons:autumn_crops` (block+item) `sereneseasons:winter_crops` (block+item) `sereneseasons:spring_crops` (block+item) `sereneseasons:summer_crops` (block+item) `sereneseasons:unbreakable_infertile_crops` (block only)

Since serene seasons doesn't do any block models/texture changing, the blocks will not change appearance. Also I have no way to control growth rates directly. Doesn't seem like I need...

> so only setting tags Yeah. You can technically do it with a datapack, but it is convenient for me to add a few lines to datagen

Is there a particular reason this can't be made as a separate addon?

> Ooh What If You Could Shoot Yourself Out Of One Too? If we go that direction it may snowball into something I can't do but nice idea regardless

Unfortunately this doesn't seem to be working any more. I get `MISSING_MATRIX_RTC_FOCUS` when attempting to start a call. Does it not look at the value of ./well-known/matrix/client?