Snshadow

Results 11 comments of Snshadow

I added the sample file in test directory and test case in version_test.go, and the test passes with the fixed code.

As I tested with two one ui 6.1 devices, looked like Galaxy devices using one ui 6.1(android 14) use 8000 port for sort of internal handling of wifi connection, causing...

https://github.com/Admiral-Billy/PokeRogue-App-Android/blob/959903439fc8f810938a5dfde229035f616a353a/app/src/main/java/com/example/pokerogueoffline/MainActivity.kt#L554-L585 The app sets the port to 8000 from here.

For anyone who have stumbled over this issue, I managed to get it work from 2.11 release branch by using the `android.config` instead of `defconfig` and then editing the configuration....

https://github.com/ntdevlabs/tiny11builder/blob/1c8480abda9c43dc0892148d02503d3d49a1b27c/README.md?plain=1#L38 This can be fixed to "You can see the description of the script by running the `get-help` command." if the PR is merged.

Although it is stated that this project is open-source, it would be nice to add the license(MIT, BSD, Apache 2.0) file as the github document says [However, without a license,...

I think that we could leave the Addref() and Release() return an error as it were before, we could check the reference count of a object then return an error...

@stffabi Oh, there are lots of things that were going on behind the scene.., thank you for the explanation! I have seen some cases when calling Release() on a already...

@gpeal Still an issue after the release with gpt-5.1-codex-max... ![Image](https://github.com/user-attachments/assets/04846ff9-ce22-4b3c-bbc1-bcd3be615e7c) ![Image](https://github.com/user-attachments/assets/e67d7a12-7f02-4fe3-b174-bf2c9dec0a39) Here is the sample git diff _from codex copy button(with paths redacted, shouldn't change the behavior)_ ``` diff --git...