Chris Beaven
Chris Beaven
Yep, if it's not in ISO 3166-1 then it's not going to be included. Add it manually as above 👍🏻
I'm not seeing the real benefit of this. Couldn't you just pipe to a file rather than introduce another new option? ``` towncrier build --draft > somefile.rst ```
They are some solid reasons, and it does seem like a good idea. Your considerations of just going with skipping committing files was my first thought too, but I can...
@umarcor coverage is configured to use [branch testing](https://coverage.readthedocs.io/en/7.2.5/branch.html#branch-coverage-measurement). The `->` is indicating that the case of line 261 skipping directly to 264 isn't tested. You'll need to also ensure you're...
> But I am also ok to review this together. It's just that it will take more time to review. Yes, I threw in a bit more than I should...
I've got an updated version of removing incremental here #491. But the issue here is `load.py` shouldn't be assuming that `config['tool']` has a `towncrier` section. This is fixed in my...
Fixed now #483 is merged 🎉
This was merged, I guess this can be closed :)
@adiroiban cool! I'd say merge this first then work on dropping the 3.7 support, otherwise I can update this after you've changed the automated tests so this doesn't fail when...
Removed the python 3.7 related fallbacks, updated the version in the toml, and rebased against trunk. (and pushing again with no change because the `checknewsfragment` test failed for no good...