Chris Beaven comments

Results 110 comments of


                                            Chris Beaven

#432 Use `importlib.metadata.version` to get the version

So something like my last commit in this PR, @RazerM ?

Provide interactive prompts to create fragments with the correct names

Implemented in #482

Add --bleeding-edge into pre-commit autoupdate

Bleeding edge isn't the solution here.

pre-commit autoupdate seems to fail

Only the `22.8.0` tag is actually on the towncrier primary (`trunk`) branch, so it's the only one that is found by pre-commit. I've updated the `23.11.0` tag to point to...

pre-commit autoupdate seems to fail

Agreed that it would be good to have them as part of the automated tests. The release PR can be merged with squash **if** the tag is applied to the...

prevent universal_newlines modifying --draft output

Wouldn't the better thing to do here be just stop opening fragments in binary mode? In `_builder.py`: ```diff - with open(full_filename, "rb") as f: - data = f.read().decode("utf8", "replace") +...

prevent universal_newlines modifying --draft output

Well if it passes the test suite then it should be fine 😂 It does seem the better fix to do it right imo

Further type hints

Let's close this for now. Good job on your commits to django-stubs :)

Document usage of conf module

Should this documentation just go under conf, or should it be part of /docs/?