Matthew Fernandez

Results 24 comments of Matthew Fernandez

Unicode tokens in the input grammar are no longer necessary for our use case, so I'm happy to close this PR if no one else needs this.

## Review checklist for @Smattr ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...

Sorry for the delay. I've been making my way through the checklist now, filing issues as I go: * https://github.com/ianfhunter/GNOLL/issues/249 * https://github.com/ianfhunter/GNOLL/issues/251 * https://github.com/ianfhunter/GNOLL/issues/252 * https://github.com/ianfhunter/GNOLL/issues/292 * https://github.com/ianfhunter/GNOLL/issues/293 Ian's been...

I get slightly different results, but they look within expected bounds. Given these tests are measuring wall clock time rather than cycles, I assume some variance is expected. It looks...

> Based on @ianfhunter 's changes and the latest results you got are you done with your review? Yes, submission looks good to me! Really cool work from Ian and...

Thanks for your interest in this project! Are you following the steps in the README? I ask because the first line of warning output from your build suggests CMake is...

This issue is quite old so perhaps you've already discovered the answer to this, but I accidentally stumbled on it myself while reading the [official docs on how to write...

Interesting, I was not aware of this nuance. If maintaining C89 compatibility is a concern, my inclination would be not to do these changes but to instead cast the affected...

Are empty structs valid in C99? I thought not, despite many compilers accepting them. For me, pycparserext (I believe correctly) rejects this as a parse error. Not really the core...