Derk-Jan Karrenbeld
Derk-Jan Karrenbeld
Please _don't_ add it to the lines as listed by @Cerberooo. The Remote IP address is _not_ a field specified by RFC 7234 and we heavily rely, spec compliantly, on...
Just back-referencing _why_ it's opening empty windows. - This commit: https://github.com/electron/spectron/commit/d74b5a0ddf500747bce30629a8be239db82edcd1 changed the launcher on windows to a `.bat`. - A `.bat` will [always launch a command window](https://superuser.com/questions/140047/how-to-run-a-batch-file-without-launching-a-command-window).
Just back-referencing _why_ it's opening empty windows. - This commit: https://github.com/electron/spectron/commit/d74b5a0ddf500747bce30629a8be239db82edcd1 changed the launcher on windows to a `.bat`. - A `.bat` will [always launch a command window](https://superuser.com/questions/140047/how-to-run-a-batch-file-without-launching-a-command-window).
Again. It has nothing to do with the version, but the technique used to spawn the process, as mentioned here https://github.com/electron-userland/spectron/issues/279#issuecomment-482069778.
If it's a different issue, you shouldn't be commenting here. If it's the same issue, my comment stands. This issue might be interesting to you: #60, and in particular this...
If I recall correctly, in order for systems such as Laravel, Rails, or reverse proxies etc. to pick this up correctly, it's not only `X-Forwarded-Host` that should be added, but...
It's in the PR template: https://github.com/radix-ui/icons/blob/master/PULL_REQUEST_TEMPLATE.md
I also ran into this (this is still tagged as need review) and it has actually broken our production envs a few times as well as leaking development and test...
Thanks @90dy I'll try taht too. For simplicity, if it created a new bundle if `app.json` (or the output of the dynamic version) changes, all these issues would go away.