Derk-Jan Karrenbeld

Results 461 comments of Derk-Jan Karrenbeld

It was me accidentally not turning off format on save. It's using the latest prettier. You can run once using `npx prettier --write .` inside the guides directory with default...

I changed the hypens only because there were 4 different casings used for IDs ánd classes (so there was no consistency). One could argue that it's more maintainable to just...

I'll pull in latest changes from #51504

@zzak there is some automated tooling to check some accessibility rules, but automated testing generally only finds a (very) limited subset. As long as we understand it's additive and not...

I have not forgotten about this. Will attempt to finish this weekend now that the other PRs are merged.

I will do a final test with my screen reader tomorrow (Monday) and then it should be good for final review.

![RTL implementation of the highlight feature](https://github.com/rails/rails/assets/1964376/fa58a254-8887-4161-b3c6-1ac3d6a03db2) The nav highlight is now also supported in RTL mode, shouldn't be flaky with flick/fast scrolling, and should now work both going up and...

> Thanks for sticking with this @SleeplessByte ! > It seems the side bar no longer scrolls when the nav highlight is outside the visible region: > https://github.com/rails/rails/assets/28561/ca82b356-e8b7-4223-93a8-3c42b4b1ce40 > >...

> Is the white text with red highlight maybe a bit too much in light mode? > > Current version: > > > This PR: > > > > >...

This is broken on the live site / main if you have smooth scrolling on, so this PR does not break it. I'm okay with trying to find a solution...