Derk-Jan Karrenbeld

Results 461 comments of Derk-Jan Karrenbeld

@A-O-Emmanuel no worries! We are not in a hurry. Right now, the exercise wants you to throw errors. It doesn't want you to *handle* the error. Handling errors could be:...

@Cool-Katt how do you feel about this?

Reopening because I want to look into this

Yes, this is the plan, but with the I/O starvation of the test runner, development on this has been halted for a little while. You can see I made a...

I don't wholly understand why https://github.com/exercism/eslint-config-typescript/blob/main/eslint.config.mjs#L10 is not capturing this (and why I don't have the issue locally). I am not opposed to this PR if it fixes the issue...

...and the answer is of course because we don't import that file :') Eh. Yah. Okay. ``` '**/#*' '.appends/**/*', '.github/**/*', '.vscode/**/*', '.yarn/**/*', '.pnp.*', 'node_modules/**/*', 'babel.config.cjs', 'jest.config.cjs', ``` This is probably...

@stefanv would you still like to contribute this PR?

Yeah it's plain wrong but I don't understand why the CI doesn't catch it...

https://github.com/Shopify/ruby-lsp/blob/369e2d1ba7c766e70273d26bf61240d2f13ee17a/test/requests/resolve_test_commands_test.rb#L70-L71 The test also seems to test for this incorrect behaviour (as in: it's being tested as if this is correct).

Yes, that works, that's how I tested it! According to [this command line reference](https://ss64.com/nt/syntax-esc.html), `$` is not special on windows. I do not know what happens on WSL though, but...