Filippo Tessarotto
Filippo Tessarotto
@keradus always pushed for avoiding such architectures for clear reasons. I think I'll propose the first production-ready version of the Fixer to completely ignore private method containing any closure
> must not be declared by interface @Ocramius you killed me :cry: this practically makes the Fixer impossible to be implemented without context awareness
> Interfaces can't declare private methods right? No, but the resulting new method can be present in the interface, and such creating a conflict
I thought this https://3v4l.org/G6vS6 could be possible but turns out it can't, so either @Ocramius knows something we don't or he was wrong; and it would be really weird for...
> One more possible edge case that (may) not be relevant yet. How about $this etc in php 7.4 arrow functions I was planning to pinpoint it in an issue...
@SpacePossum may we tag this for 2.17?
If you want to keep PR list clean, feel free to PR against my fork, I'll merge your fix without squashing it
> 3276 was about changing FQCN to short CN, why doing the reverse ? The topic reports the Expected VS Actual diff of the test, nothing to reverse here.
> Personally, I am removing these kind of hard to maintain @param docblocks since they do not make any sense when using strict types anymore. Heh, if only we could......
> I treated your opening post as feature request definition, not as output of failing test :D You are right, it was misleading. I do so for bug reports, but...