Filippo Tessarotto

Results 335 comments of Filippo Tessarotto

It is important to underline that the current PHPUnit 4.8 version **skips** some tests, and a lot of bugs are missing from the test suite!

Before: only 820 tests found (https://travis-ci.org/paypal/PayPal-PHP-SDK/jobs/371267312#L280) After: 972 tests found (https://travis-ci.org/paypal/PayPal-PHP-SDK/jobs/406270465#L236)

Indeed, I've opened a PR

Any PR is welcome :+1:

> hidden in the pull requests :open_mouth:

For sake of completeness, this has also been discussed in Slack: https://laminas.slack.com/archives/C4QBQUEG5/p1623930860223800 ![image](https://user-images.githubusercontent.com/152236/122521123-bd5f6100-d014-11eb-9063-9926730d9ef4.png)

> The helper FormCollection already contains a "wrapper" functionality. Maybe we can adopt this functionality to all helper with multiple elements and also for the FormRow helper itself. That's indeed...

> if you have any nice idea how to deal with it, feel free to propose. Well, the following is not a solution, but an idea. As you pointed out,...

The code is raw and does something that is 90% alike of your project (written long before I knew it), although is 100% tested: 1. `'Class'` => `Class::class` https://github.com/Slamdunk/phpunit-extensions/blob/master/lib/ClassStandardsTrait.php#L242 1....