SkytilsMod icon indicating copy to clipboard operation
SkytilsMod copied to clipboard

fix: smolpeople breefingdog player sizing

Open P3nguinMinecraft opened this issue 5 months ago • 6 comments

  • spoofing isBaby() does not work anymore
  • changing player size for smolpeople and breefingdog will be done in PlayerEntityRenderer mixin, scaling the MatrixStack by 0.5f
  • another issue is by lazy was not going to work because all players would share the same hook instance, so I just made the smol / breefing check per call

I am not quite sure if I matched the extension / hook system well

P3nguinMinecraft avatar Jul 07 '25 07:07 P3nguinMinecraft

im actually so bad at branches bruh accidentally added null world age fix in here somehow

P3nguinMinecraft avatar Jul 07 '25 07:07 P3nguinMinecraft

Wouldn't these changes now break smolpeople on 1.8. Due to the presenece of preprocessing in the repo id assume there are still 1.8 releases planned so instead of removing the old code you would prob have to preprocess it out instead

CalMWolfs avatar Jul 07 '25 07:07 CalMWolfs

I can fix the commits in a bit.

Sychic avatar Jul 07 '25 12:07 Sychic

Is there a reason why the logic is now performed in the mixin itself? It would make more sense imo to simply retain the existing logic (lazy caches the value once computed).

Sychic avatar Jul 11 '25 14:07 Sychic

Is there a reason why the logic is now performed in the mixin itself? It would make more sense imo to simply retain the existing logic (lazy caches the value once computed).

caching the value was an issue because it kept computing before you loaded in or smth and you would have to change lobbies to apply settings changes

P3nguinMinecraft avatar Jul 12 '25 02:07 P3nguinMinecraft

Can you change the behavior so 1.8.9 works the same way then?

Sychic avatar Jul 13 '25 13:07 Sychic