SkytilsMod icon indicating copy to clipboard operation
SkytilsMod copied to clipboard

Feature(s): Click prevention on a few things (restores #430)

Open RayDeeUx opened this issue 1 year ago • 2 comments

restores #430. original description below.

  • Pickup minion
  • Mayor voting
  • Wardrobe unequiping
  • Abiphone calling

TAB key is a bit unorthodox of a key to hold to bypass the preventions, but as a macOS user I don't trust whatever comes out of Ctrl-click (macOS has some system-specifc "ctrl + click = right click" schtick that I'm not a big fan of). I was going to use ALT, but Hypixel seems to use that key pretty often as a stand-in for mouse button clicks, and LMETA triggers the Windows start menu, so TAB it is unless if there's better ideas.

RayDeeUx avatar Jan 08 '24 20:01 RayDeeUx

This PR has 82 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +81 -1
Percentile : 32.8%

Total files changed: 2

Change summary by file extension:
.kt : +81 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.


Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.

Why not use Cmd on macOS and Ctrl on other platforms, like in SkyHanni?

lunaynx avatar Feb 02 '24 16:02 lunaynx