Diana Křepinská

Results 25 comments of Diana Křepinská

I was able to fix this error `keytool error: java.security.KeyStoreException: sun.security.pkcs11.wrapper.PKCS11Exception: CKR_SESSION_READ_ONLY` by running the keytool command with `sudo`

> I've just looked at the basics on this one. I'll leave review of the actual tests to others. :) @bstansberry Thank you for review. I fixed it and did...

> @Skyllarr It is easier for the mergers if you add a link to the core pull request in the description rather than just the WFCORE Jira issue. I've edited...

> The following artifacts are not added to jboss-client.jar in this PR, as they appear not applicable on the client side, but I may be wrong: > elytron-audit elytron-jacc elytron-oidc...

> @Skyllarr Thanks for your time to review and the valuable feedback. I have fixed the issues. Regarding the links: What are you using for review? Github won't work. In...

@fjuma Thanks for review! I have updated my PR accordingly. Can you please review again?

@darranl Thank you Darran, I updated this PR with a fix and CI is running now

@ivassile as @OndrejKotek mentioned, I would also expect to add a brief note about `encoding` attribute under `File audit log` (it is in the same file just above ) and...

to render an image click on [view file ](https://github.com/wildfly/wildfly-proposals/blob/665363cbea80c8b3512ac77f29e5bf220814062b/elytron/WFLY-16555-http-digest-support-with-load-balancer.adoc) in the PR's changed files