Jasmin Savard

Results 473 comments of Jasmin Savard

I've assigned myself to review this one. I need to test it to see how it will improve or break actual indexing.

Yeah, sorry, the news is I'm busy with Media Gallery and trying to find time to think about these when not fixing other bugs :smile:

I think Playwright is the next thing we should look at. Though we need a POC for that and we need to see what is missing in Playwright because it...

Sorry need to find time these days. Made myself a reviewer of this one.

I'm questioning myself if it's not already fixed. Remember vaguely working on fixing these a while ago.

To be honest. I'm refactoring the Media gallery to Vue 3 right now in a PR. This will probably change the way we initialize the Media Gallery entirely. I would...

No we can't replace NEST with the new Elasticsearch client without refactoring some parts of the Elasticsearch module. It will also remove support to some older versions of Elasticsearch so...

@sebastienros Here is one that is interesting to review. Looks like an interesting way to use Blazor. Need to analyze if it's better over an actual Vue app.

Just comparing the amount of code necessary for this with the Vue app. https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/OptionsEditor/optionsEditor.js Here we have a 91 lines of code to achieve this vs all this code for...