OrchardCore icon indicating copy to clipboard operation
OrchardCore copied to clipboard

Blazor Web Component Blazor POC

Open Skrypt opened this issue 2 years ago • 7 comments

@ns8482e Just creating a draft PR here as it is easier for me to review.

Related discussion: https://github.com/OrchardCMS/OrchardCore/discussions/15653

Skrypt avatar Apr 02 '24 22:04 Skrypt

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Apr 02 '24 22:04 github-actions[bot]

@sebastienros Here is one that is interesting to review. Looks like an interesting way to use Blazor. Need to analyze if it's better over an actual Vue app.

Skrypt avatar Apr 02 '24 23:04 Skrypt

Just comparing the amount of code necessary for this with the Vue app.

https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.ContentFields/Assets/js/OptionsEditor/optionsEditor.js

Here we have a 91 lines of code to achieve this vs all this code for Blazor to create the same thing. Blazor will require a lot more code management.

Skrypt avatar Apr 03 '24 12:04 Skrypt

personally i would favor vanilla javascript and .net code over vue.js even if ir means more lines of code.

giannik avatar Apr 03 '24 14:04 giannik

What is .NET code these days? Typescript with Vue.js or anything else is C# syntax like too ... I need to take a deeper look later on and review this PR more.

Skrypt avatar Apr 03 '24 15:04 Skrypt

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] avatar Apr 16 '24 16:04 github-actions[bot]

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

github-actions[bot] avatar Jun 16 '24 02:06 github-actions[bot]

Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it.

github-actions[bot] avatar Jul 02 '24 02:07 github-actions[bot]