Sergii Nechuiviter comments

Repositories
Issues
Comments

Results 4 comments of


                                            Sergii Nechuiviter

Fix Dataset builder pattern. Decouple Dataset and reader.

1. What do you mean by "the PR"? 2. Yes, I will fix tests.

Fix Dataset builder pattern. Decouple Dataset and reader.

Fastfix reader call in PredefinedKFold.split. Actually, `reader` should not be called from `PredefinedKFold.split` because it leads to extra coupling. So I think a bit more redesign is needed. I will...

Fix Dataset builder pattern. Decouple Dataset and reader.

1. Move data preprocessing for building data sets into the dedicated functions (`load_from_df` and `load_from_file`) away from initializer (so `DatasetAutoFolds.__init__` will become trivial). 2. Move `read_ratings` to `Reader` because it...

Unified LLM Provider & Model Discovery with LiteLLM

I think it is a great idea to use LiteLLM. I have a couple of suggestions: - remove from PR unrelated changes, like removal of debug prints. - don't change...