Sjors Provoost

net: additional disconnect logging

13

While debugging unexpected disconnections, possibly related to #28331, I found some additional [net] logging to be useful. All cases where we disconnect now come with a log message that has...

Remove Taproot activation height

10

Drop `DEPLOYMENT_TAPROOT` from `consensus.vDeployments`. Now that the commit (https://github.com/bitcoin/bitcoin/commit/7c08d81e119570792648fe95bbacddbb1d5f9ae2) which changes taproot to be enforced for all blocks ~is sufficiently buried by other commits, and thus less likely to be...

getblocktemplate improvements for segwit and sigops

6

This adds the following commits: 1. remove unnecessary check for whether SegWit is active 2. drop no longer relevant warning about missing sigops field 3. warn that CheckBlock() underestimates sigops...

ParseHDKeypath: support h as hardened marker

5

BIP32 allows both `'` and `h` as hardened derivation marker. Our legacy wallet uses `'`. Since #26076 our descriptor wallets use `h` by default. `ParseHDKeypath` only supports `'`. It's currently...

Make (Read/Write)BinaryFile work with char vector, use AutoFile

19

ReadBinaryFile and WriteBinaryFile current work with `std::string`. This PR adds support for `std::vector>`. It also uses `AutoFile` now. This is [update: probably _not_] used in #28983 to store the static...

Show transactions as not fully confirmed during background validation

8

Fixes #28598: currently if assumeutxo were to be used, transactions might get shown as confirmed even while the entire chainstate is unconfirmed. This also adds an `assumed` value to `listtransactions`...

Drop -dbcache limit

32

Due to recent UTXO set growth, the current maximum value for `-dbcache` of 16GB is ~just months away from being~ insufficient (for those who wish to complete IBD with the...

Move log messages: tx enqueue to mempool, allocation to blockstorage

12

When running with `-debug=validation` the log is filled with: ``` 2023-03-19T12:46:01Z [validation] Enqueuing TransactionAddedToMempool: txid=37c8e1ef87d75a67fbaf44e116018fbc70d9c4ef0e27e2ae56861395101f9b8e wtxid=24e2d76012f9cde451d085ead4feab136feddae6cb55d37221a81aac6c0eaf42 2023-03-19T12:46:01Z [validation] TransactionAddedToMempool: txid=37c8e1ef87d75a67fbaf44e116018fbc70d9c4ef0e27e2ae56861395101f9b8e wtxid=24e2d76012f9cde451d085ead4feab136feddae6cb55d37221a81aac6c0eaf42 ``` These log entries are more appropriate for `-debug=mempool`....

signet: fixing mining for OP_TRUE challenge

3

[BIP325](https://github.com/bitcoin/bips/blob/master/bip-0325.mediawiki) mentions the following rule: > In the special case where an empty solution is valid (ie scriptSig and scriptWitness are both empty) this additional commitment can optionally be left...

Support self hosted Github workers on forks

12

I find myself making pull requests against my fork (mostly on top of #28983), or asking others to do so. Since I don't want to splurge on a Cirrus account,...