Sjors Provoost

Results 247 issues of Sjors Provoost

Finally someone wrote up the informal "BIP48" into an actual [BIP 48](https://github.com/bitcoin/bips/blob/master/bip-0048.mediawiki). Double check that we actually implement this, before moving over to BIP 87 (#52).

The sign button is disabled when `psbt.canSign` returns false. We should make it more clear why this happens. This may require a PR to `libwally-swift`. `canSign` is implemented here: https://github.com/blockchain/libwally-swift/blob/master/LibWally/PSBT.swift#L54-L73...

We currently use `m/48h/0h/2h`. The new [BIP 87](https://github.com/bitcoin/bips/blob/master/bip-0087.mediawiki) suggests a simpler derivation path `m/87h/0h`. This requires checking: * if Specter supports it * if other hardware wallet special case `m/48h/0h/2h`...

Perhaps this should be done upstream in libwally-swift. Is it possible to produce more useful previews of things like HDKey and fingerprints for debugging?

This seems to happen every 2nd time I click it. `precondition(activeFileViewControllerManager == nil)` fails in `SignViewController` `openPSBT`

It might be useful if the device can verify that inputs being spent actually exist(ed in the past). But it may not be very practical. 1. The PSBT standard would...

Depending on what works best, QR codes should perhaps always have a white background, even in dark mode.

I'd like to be able to prove that the TestFlight and App Store binaries are actually derived from this source code. As a first step I've uploaded the binary to...

Uses https://github.com/ElementsProject/libwally-core/pull/370 See wish list: https://github.com/ElementsProject/libwally-core/issues/366 Plan is to merge this once some of the wish list is implemented (and there's a new libwally release).

This currently fails testSignWithHDKey with a WALLY_EINVAL.