Sjoerd Langkemper

https://github.com/returntocorp/pfff/pull/544

I tried [creating automatic tests for this](https://github.com/Sjord/semgrep/blob/test_equivalency/semgrep-core/src/parsing/Unit_parsing.ml#L44-L56), which would compare the AST of tree-sitter and pfff. However, naively comparing the ASTs with `pfff_ast ts_ast` didn't work. Perhaps because of differing...

This was due to a difference between pfff and tree-sitter. Pfff can't handle uppercase true, so this causes the program to be parsed with tree-sitter. Tree-sitter parses `die()` as `die()`,...

See also [[PHP] Handle case insensitive parts of code · Issue #3963 · returntocorp/semgrep](https://github.com/returntocorp/semgrep/issues/3963)

Currently, parsing is first attempted with pfff, and when that fails parsing is done with tree-sitter. Keeping this for files and parsing the pattern with tree-sitter would not solve this...

@aryx Is it the goal to keep both pfff and tree-sitter and make the AST as similar as possible?

Related: * [Parse more keywords and language constructs · Issue #144 · tree-sitter/tree-sitter-php](https://github.com/tree-sitter/tree-sitter-php/issues/144) * [Arrow functions sometime prevent matching · Issue #5594 · returntocorp/semgrep](https://github.com/returntocorp/semgrep/issues/5594)

> see messaging in community slack This seems to refer to [this message](https://r2c-community.slack.com/archives/CK86BJ5DW/p1644290152751169): Pablo Estrada (r2c): > Hi all, > > We’re announcing upcoming changes to Semgrep & rules licensing:...

This seems to be solved in [Feat/available services by max-wittig · Pull Request #1075 · python-gitlab/python-gitlab](https://github.com/python-gitlab/python-gitlab/pull/1075)

I could reproduce this. With `with_labels_details=False`, issue.labels contains a list of label names: `["bar","foo"]`. With `with_labels_details=True`, issue.labels contains a list of dicts with label info: `[{"id":204,"name":"bar","description":null,"description_html":"","text_color":"#FFFFFF","color":"#6699cc"},{"id":203,"name":"foo","description":null,"description_html":"","text_color":"#FFFFFF","color":"#6699cc"}]`. When saving, the dict...