Sjoerd Langkemper comments

Results 204 comments of


                                            Sjoerd Langkemper

PHP namespace pattern raises Impossible

It's [this one](https://github.com/returntocorp/pfff/blob/0e349b40e6abd21e4e33e9cc05a6528f2f1c14a8/lang_php/analyze/ast_php_build.ml#L174) in toplevel: | NamespaceDef (_, _, _) -> raise Impossible

ValueError PosixPath has an empty name when running test on single config

I just copied [this one](https://github.com/returntocorp/semgrep-rules/blob/develop/csharp/lang/security/stacktrace-disclosure.yaml) to an empty directory, but I get this problem with any rule file. Can you reproduce it?

ValueError PosixPath has an empty name when running test on single config

"Fetching configuration from semgrep.dev" shown even when not logged in

Yes, that's correct. I would expect the `logger.info` to be inside the `if scan_handler`.

"Fetching configuration from semgrep.dev" shown even when not logged in

Rule to detect secrets in build time arguments in Docker

@p4p3r Could you take another look at this?

Ruby %w operator stops from match pattern

This seems due to a difference between pfff and tree-sitter parsing. Ruby files are parsed preferentially by tree-sitter, and patterns by pfff. If we have this file: ``` foo =...

semgrep --test does not scan current directory in docker

@spencerdrak What do you think of this issue?

Registry shows use-frozen-lockfile-pipenv instead of use-frozen-lockfile-pip

Also, `use-frozen-lockfile-pip` [was renamed recently](https://github.com/returntocorp/semgrep-rules/commit/fd6000169ec1034af400f08872291db87db45522), so I think `use-frozen-lockfile-pip` should be removed from the registry?

Registry shows use-frozen-lockfile-pipenv instead of use-frozen-lockfile-pip

@underyx Could you take a look at this?